Add Cosmos3 action generation support#13823
Conversation
dg845
left a comment
There was a problem hiding this comment.
Thanks for the PR! Left some initial comments :).
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yiyixuxu
left a comment
There was a problem hiding this comment.
thanks, I left some feedbacks
| resolution (no upscaling), wastes compute on padding, and is a train/inference mismatch that can hurt | ||
| quality. | ||
| raw_action_dim (`int`, *optional*): | ||
| Number of meaningful (unpadded) action channels to keep when slicing predicted actions. Required for |
There was a problem hiding this comment.
is the value fixed for each domain_name?
if not, how should a user configure it?
There was a problem hiding this comment.
We can indeed map raw_action_dim from domain_name for nearly all domains, so I've added that table and dropped the required arg in commit. Two domains depend on dataset config instead, resulting in different raw_action_dim values: e.g. for libero width changes with the rotation representation (axis-angle 3D / 6D / 9D -> 7/10/13 total, will follow up on support for libero and hand_pose.
What does this PR do?
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.